Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

green-code-initiative/ecoCode#63 - Fix pluginKey definition to conform to SonarSource Marketplace rules #73

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

jycr
Copy link
Contributor

@jycr jycr commented Mar 8, 2023

From Deploying to the Marketplace - Requirements:

  1. The key of your plugin must be:
    1. short and unique
    2. lowercase (no camelcase)
    3. composed only of [a-z0-9]
    4. related to the name of your plugin
    5. not just the name of a language (e.g. cannot be java, rust, js/javascript, …)
      examples of good keys: motionchart, communityphp, scmactivity

…arSource Marketplace rules

From [Deploying to the Marketplace - Requirements](https://community.sonarsource.com/t/deploying-to-the-marketplace/35236):

3. The key of your plugin must be:
   1. short and unique
   2. lowercase (no camelcase)
   3. composed only of [a-z0-9]
   4. related to the name of your plugin
   5. not just the name of a language (e.g. cannot be java, rust, js/javascript, …)
      examples of good keys: motionchart, communityphp, scmactivity
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dedece35
Copy link
Member

dedece35 commented Mar 9, 2023

Hi @jycr,
ok for me.
please apply the same modifications to out 2 mobile plugins in https://github.com/green-code-initiative/ecoCode-mobile with a PR

@jycr
Copy link
Contributor Author

jycr commented Mar 9, 2023

please apply the same modifications to out 2 mobile plugins in https://github.com/green-code-initiative/ecoCode-mobile with a PR

Already done: green-code-initiative/ecoCode-android#27 ;-)

@dedece35
Copy link
Member

dedece35 commented Mar 9, 2023

@jycr, ah ! ok ! sorry, I didn't check it :p

@dedece35 dedece35 merged commit 6d9b22a into green-code-initiative:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants